🐛 agent now starts the volume cleanup task #7346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7346 +/- ##
===========================================
- Coverage 87.35% 68.04% -19.32%
===========================================
Files 1704 680 -1024
Lines 66205 32096 -34109
Branches 1124 168 -956
===========================================
- Hits 57833 21839 -35994
- Misses 8052 10199 +2147
+ Partials 320 58 -262
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
GitHK
requested review from
bisgaard-itis,
giancarloromeo,
matusdrobuliak66 and
pcrespov
pcrespov
approved these changes
Mar 12, 2025
services/agent/src/simcore_service_agent/services/volumes_manager.py
Outdated
Show resolved
Hide resolved
giancarloromeo
approved these changes
Mar 12, 2025
added 2 commits
March 12, 2025 12:35
…HK/osparc-simcore-forked into pr-osparc-enable-volume-cleanup-task
Contributor
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at c45aea2 |
|
GitHK
added
🤖-automerge
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
Co-authored-by: Andrei Neagu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Big ops here. Started te wrong task. Let's look at the bright side, the task per se was never used but tested 🤦
Related issue/s
How to test
Dev-ops checklist